Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin the Alpine Arm32 image to previous tag (#94683)" #95359

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

CarnaViire
Copy link
Member

This reverts commit 46c8a66.

Enabling the rolling Alpine Arm32 image back, as the problem was mitigated in a different way in dotnet/dotnet-buildtools-prereqs-docker#933

Contributes to #91757, dotnet/dnceng#1423

I will backport this to release/8.0-staging as soon as it will be merged.

cc @wfurt @carlossanlop @dougbu FYI

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 28, 2023
@ghost ghost assigned CarnaViire Nov 28, 2023
@CarnaViire CarnaViire added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 28, 2023
@ghost
Copy link

ghost commented Nov 28, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This reverts commit 46c8a66.

Enabling the rolling Alpine Arm32 image back, as the problem was mitigated in a different way in dotnet/dotnet-buildtools-prereqs-docker#933

Contributes to #91757, dotnet/dnceng#1423

I will backport this to release/8.0-staging as soon as it will be merged.

cc @wfurt @carlossanlop @dougbu FYI

Author: CarnaViire
Assignees: CarnaViire
Labels:

area-Infrastructure

Milestone: -

@CarnaViire
Copy link
Member Author

CarnaViire commented Nov 28, 2023

Hmmm... it seems like the image has not updated yet, for some reason? It still points to the "wrong" commit microsoft/msquic@7ea0e2e (log)

/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
MsQuic supported and using 'libmsquic.so 2.3.0.0 (7ea0e2e640008ad5c86d8d31e0cd186399b6b404)'.

It should point to microsoft/msquic@b7b2d5e (v2.2.2) instead (see dotnet/msquic@dc5560c) 😕 I'll take a look, or maybe @wfurt could take a look as well.

UPD:
yeah, it seems that there were some kind of problems with rebuilding images in general; trying to trigger the build for Alpine images specifically (cc @lbussell FYI)

@wfurt
Copy link
Member

wfurt commented Nov 28, 2023

CI build failed so no new image was published. We shall roll to 3.16 once I'mages are available. I'll put up change when ready.

@CarnaViire
Copy link
Member Author

The image was successfully rebuilt yesterday, now I can see in the logs that the image points at the correct release commit, and the Quic tests are passing normally (log)

/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.Net.Quic.Functional.Tests (method display = ClassAndMethod, method display options = None)
MsQuic supported and using 'libmsquic.so 2.2.2.0 (b7b2d5e6df9c98ec8bad6d8dc8c6ef1a0e892abd)'.

@CarnaViire
Copy link
Member Author

CI is completely green. I would then suggest to merge and backport the change as is (to be able to fix dotnet/dnceng#1423), and deal with the updating to 3.16+ later, and in main only @wfurt

@CarnaViire
Copy link
Member Author

@hoyosjs @carlossanlop @ViktorHofer @dotnet/ncl can someone pls review?

@CarnaViire CarnaViire merged commit 92130dc into dotnet:main Nov 29, 2023
102 checks passed
@CarnaViire
Copy link
Member Author

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7035388070

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants