Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Base64 decoding regressions from whitespace handling #86396

Merged
merged 3 commits into from
May 18, 2023

Conversation

stephentoub
Copy link
Member

Put the main code paths back to how they were before, with the sole exception being an extra method argument and an extra check in the InvalidData exit section that delegates to a helper if that method argument is true.

Fixes #86336
Fixes dotnet/perf-autofiling-issues#17837

Put the main code paths back to how they were before, with the sole exception being an extra method argument and an extra check in the InvalidData exit section that delegates to a helper if that method argument is true.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 17, 2023
@ghost ghost assigned stephentoub May 17, 2023
@stephentoub
Copy link
Member Author

(Note there also appears to be a stale static PGO data aspect to the cited regressions on coreclr.)

@stephentoub stephentoub added area-System.Memory and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 17, 2023
@ghost
Copy link

ghost commented May 17, 2023

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Put the main code paths back to how they were before, with the sole exception being an extra method argument and an extra check in the InvalidData exit section that delegates to a helper if that method argument is true.

Fixes #86336
Fixes dotnet/perf-autofiling-issues#17837

Author: stephentoub
Assignees: stephentoub
Labels:

area-System.Memory, needs-area-label

Milestone: -

@stephentoub
Copy link
Member Author

cc: @gfoidl

Copy link
Member

@gfoidl gfoidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes, otherwise LGTM. Nice layering 👍🏻

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adamsitnik adamsitnik added the tenet-performance Performance related issue label May 18, 2023
@stephentoub stephentoub merged commit 2f18df4 into dotnet:main May 18, 2023
@stephentoub stephentoub deleted the fixbase64regression branch May 18, 2023 13:21
@ghost ghost locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants