Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReadOnlySpanGetReferenceAndReadInteger on BigEndian #85969

Merged
merged 2 commits into from
May 9, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented May 9, 2023

Addresses #85127 (comment)

@ghost ghost assigned EgorBo May 9, 2023
@EgorBo EgorBo changed the title fix ReadOnlySpanGetReferenceAndReadInteger on BE Fix ReadOnlySpanGetReferenceAndReadInteger on BigEndian May 9, 2023
@ghost
Copy link

ghost commented May 9, 2023

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: EgorBo
Assignees: -
Labels:

area-System.Memory

Milestone: -

@EgorBo
Copy link
Member Author

EgorBo commented May 9, 2023

Wasm failures #85949, I assume it's not worth running extra-platforms pipeline for a trivial change.

@EgorBo EgorBo merged commit dd3a027 into dotnet:main May 9, 2023
@EgorBo EgorBo deleted the fix-test-on-bigendian branch May 9, 2023 14:25
@akoeplinger
Copy link
Member

@EgorBo looks like the test still fails on s390x: https://dev.azure.com/dnceng-public/public/_build/results?buildId=273447&view=ms.vss-test-web.build-test-results-tab&runId=5405384&resultId=147326&paneView=debug

Assert.Equal() Failure
Expected: 28429436511322223
Actual:   7494100832430877696



Stack trace
   at System.SpanTests.MemoryMarshalTests.ReadOnlySpanGetReferenceAndReadInteger() in /_/src/libraries/System.Memory/tests/MemoryMarshal/GetReference.cs:line 113
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object obj, IntPtr* args) in /_/src/mono/System.Private.CoreLib/src/System/Reflection/MethodInvoker.Mono.cs:line 30
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr) in /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs:line 59

@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants