[release/6.0] Fix HTTTP/2 header decoder buffer allocation #85341
Conversation
* Add test for literal field without name reference * Fix header name buffer allocation * Add more tests * Unified QPackDecoderTest test files * Fix variable name * Fixed HPackDecoder and ported QPack tests * Feedback --------- Co-authored-by: ManickaP <mapichov@microsoft.com>
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #78516 Backports #78862 Customer impactReliability problem in HTTP/2, where some requests/responses with large headers that should be accepted might end up throwing exception.
This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET. TestingAdded tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI. RiskLow, as this affects only HPack in (rare) case of 4KB+ sized headers data buffers.
|
|
Failures look like #76454, timeouts with machine provisioning and/or test execution. |
|
Approved by Tactics (@SteveMCarroll) on 4/27 via email. Marking as servicing-approved. |
There was a problem hiding this comment.
Same request as in the 7.0 PR - Rebase to release/6.0-staging, and make sure to merge before May 15th (code complete) if you intend to include this fix in the June Release.
ghost
added
the
needs-author-action
|
Closed in favor of #85976 |
Fixes #78516
Backports #78862
Customer impact
Reliability problem in HTTP/2 (HPack), where some requests/responses with large headers (4KB+) that should be accepted might end up throwing exception.
This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET.
Testing
Added tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI.
Risk
Low, as this affects only (rare) case of 4KB+ headers data buffers in HTTP/2 (HPack).