Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] bump System.Text.Json timeout #85041

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[browser] bump System.Text.Json timeout #85041

merged 2 commits into from
Apr 20, 2023
+4 −4

Conversation

pavelsavara
Copy link
Member

Increase timeout for System.Text.Json timeout to 45 minutes

Fixes #84434

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Text.Json labels Apr 19, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Apr 19, 2023
@pavelsavara pavelsavara self-assigned this Apr 19, 2023
@ghost
Copy link

ghost commented Apr 19, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Increase timeout for System.Text.Json timeout to 45 minutes

Fixes #84434

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Text.Json
Milestone: 8.0.0

@build-analysis build-analysis bot mentioned this pull request Apr 19, 2023
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 19, 2023 15:19
@pavelsavara pavelsavara requested a review from lewing April 19, 2023 15:19
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 19, 2023
Closed
Closed
Closed
@pavelsavara pavelsavara merged commit 9aac647 into dotnet:main Apr 20, 2023
@pavelsavara
Copy link
Member Author

There is another timeout set to 1800s, I'm confused https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-85167-merge-12dff3b5d2ad4b3381/WasmTestOnBrowser-System.Text.Json.Tests/1/console.1455c32f.log?helixlogtype=result

@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
@pavelsavara pavelsavara deleted the browser_SystemTextJson_timeout branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical left review comments

@maraf maraf maraf approved these changes

@lewing lewing Awaiting requested review from lewing

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Text.Json
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

WasmTestOnBrowser-System.Text.Json.Tests.WorkItemExecution timing out
3 participants
@pavelsavara @radical @maraf