Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize primitive types in ReflectionXmlSerializationWriter using char[]. #81687

Conversation

TrayanZapryanov
Copy link
Contributor

@TrayanZapryanov TrayanZapryanov commented Feb 6, 2023

Follow up of #76436
More primitives are serialized into char buffer and then written into writer, instead of serialized to string.

Please ignore commits before last one - I will rebase once #76436 is in the main.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 6, 2023
@TrayanZapryanov TrayanZapryanov marked this pull request as draft February 6, 2023 09:04
@ghost ghost closed this Mar 8, 2023
@ghost
Copy link

ghost commented Mar 8, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@TrayanZapryanov TrayanZapryanov deleted the use_typed_primitives_buffer_in_reflectionwriter branch April 7, 2023 12:51
@ghost ghost locked as resolved and limited conversation to collaborators May 7, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Serialization community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant