Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the SSE fallback for Vector3.Dot masks off the unused element of op1 and op2 #74932

Merged
merged 3 commits into from
Sep 2, 2022
Merged

Ensure that the SSE fallback for Vector3.Dot masks off the unused element of op1 and op2 #74932

merged 3 commits into from
Sep 2, 2022

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Sep 1, 2022 •
edited
Loading

This resolves #72149

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 1, 2022
@ghost ghost assigned tannergooding Sep 1, 2022
@ghost
Copy link

ghost commented Sep 1, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This resolves #74857

Author: tannergooding
Assignees: tannergooding
Labels:

area-CodeGen-coreclr
Milestone: -

@tannergooding
Copy link
Member Author

CC. @jkotas

jkotas
jkotas approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Somebody on @dotnet/jit-contrib should take a look as well.

@JulieLeeMSFT
Copy link
Member

Thanks @tannergooding. Please backport to 7.0 once CI is green.

@tannergooding tannergooding merged commit ca82565 into dotnet:main Sep 2, 2022
@tannergooding
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2976383148

@github-actions github-actions bot mentioned this pull request Sep 2, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
@tannergooding tannergooding deleted the fix-74857 branch November 11, 2022 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorBo EgorBo EgorBo approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@tannergooding tannergooding

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

matrix4x4createfromaxisangletest failing on NativeAOT
4 participants
@tannergooding @JulieLeeMSFT @EgorBo @jkotas