Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullability annotation on CacheControlHeaderValue #74863

Merged
merged 6 commits into from
Sep 5, 2022
Merged

Add nullability annotation on CacheControlHeaderValue #74863

merged 6 commits into from
Sep 5, 2022

Conversation

pierrebelin
Copy link
Contributor

Add nullability annotation on CacheControlHeaderValue.TryParse inside System.Net.Http

Fix #74061

@pierrebelin
Add nullability annotation on CacheControlHeaderValue
20b64ed 
Add nullability annotation on CacheControlHeaderValue.TryParse inside System.Net.Http

Fix #74061
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 31, 2022
@ghost
Copy link

ghost commented Aug 31, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Add nullability annotation on CacheControlHeaderValue.TryParse inside System.Net.Http

Fix #74061

Author: pierrebelin
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@dnfadmin
Copy link

dnfadmin commented Aug 31, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@pierrebelin
Copy link
Contributor Author

Thanks for the answer @MihaZupan.
This is my first issue on dotnet so I'm quite discover everything.

I've a question, why tests on System.Net.Http are all working on Visual Studio and not inside the pipeline ? Do you have a specific command to reproduce it ?

Do you know about that ?

MihaZupan
MihaZupan approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pierrebelin!

Re:

I've a question, why tests on System.Net.Http are all working on Visual Studio and not inside the pipeline ? Do you have a specific command to reproduce it ?

Have you followed the requirements and build instructions for libraries docs? Did they hit any errors?

src/libraries/System.Net.Http/tests/UnitTests/Headers/CacheControlHeaderValueTest.cs Outdated Show resolved Hide resolved
src/libraries/System.Net.Http/src/System/Net/Http/Headers/CacheControlHeaderValue.cs Outdated Show resolved Hide resolved
@MihaZupan
Copy link
Member

Test failure is #74896

@MihaZupan MihaZupan merged commit 3ec9617 into dotnet:main Sep 5, 2022
@MihaZupan MihaZupan added this to the 8.0.0 milestone Sep 5, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

Nullability annotation missing on CacheControlHeaderValue.TryParse
4 participants
@pierrebelin @dnfadmin @MihaZupan @stephentoub