Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend usage of GC_ALLOC_ALIGN8 #104781

Merged
merged 1 commit into from
Jul 13, 2024
Merged

Commits on Jul 12, 2024

  1. Extend usage of GC_ALLOC_ALIGN8

    In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
    requirements on ARM, but for performance we also like to 8 byte align
    double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
    that does that but it was only being used in the ARM case and we had
    a more complicated workaround being used elsewhere. This change expands
    GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
    all our aligned double arrays to use that approach.
    
    GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
    aligned, not that it will stay aligned after relocation. On ARM it will
    stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
    on other 32 bit architectures it is not guaranteed to stay aligned.
    noahfalk committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3a7c4ea View commit details
    Browse the repository at this point in the history