-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0][mono][HybridGlobalization] Fix ShortDatePattern year format to be "yyyy" #100810
[release/8.0][mono][HybridGlobalization] Fix ShortDatePattern year format to be "yyyy" #100810
Conversation
Tagging subscribers to this area: @dotnet/area-system-globalization |
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 8.0.x
@vitek-karas can you take a look at the CI failures? |
Failures are known as the same tests can be found failing on a combination of https://dev.azure.com/dnceng-public/public/_build/results?buildId=642490&view=results, https://dev.azure.com/dnceng-public/public/_build/results?buildId=641494&view=logs&j=12cf7a0b-4da0-5b17-37e7-24aa7cbf9869, or https://dev.azure.com/dnceng-public/public/_build/results?buildId=638193 One exception is |
Took a second look after re-run and all failing tests seem unrelated and are already present on the |
47afa79
into
dotnet:release/8.0-staging
Customer Impact
When using Hybrid Globalization mode on Apple mobile platforms with .NET 8, we are returning
ShortDatePattern
in ICU-like format instead of .NET-like format. This PR fixes this by normalizing the short date format returned from Apple ICU and converting "yy" year format to the expected "yyyy"Hybrid Globalization mode in .NET 8 is off by default, so this only affects applications where the developer explicitly opted into using this mode.
NOTE: This is a .NET 8 version of #99908.
Regression
Testing
We added a small set of tests to verify the correct functionality of the fix.
Risk
Low, only affects scenarios where Hybrid Globalization mode on Apple mobile platforms is enabled.
fyi: @vitek-karas @mkhamoyan @ilonatommy @akoeplinger @steveisok