Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][MT] smaller thread pool #100415

Merged
merged 4 commits into from
Apr 3, 2024
Merged

[browser][MT] smaller thread pool #100415

merged 4 commits into from
Apr 3, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Mar 28, 2024 •
edited
Loading

  • smaller p-thread pool
  • drop thread_available
    • we can do that because no managed code s running on UI thread. And so we are safe to block the managed thread until UI creates another thread
  • configure some tests to keep more threads ready

Fixes #75602

@pavelsavara
- smaller thread pool
ecba364 
- drop thread_available
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm labels Mar 28, 2024
@pavelsavara pavelsavara added this to the 9.0.0 milestone Mar 28, 2024
@pavelsavara pavelsavara self-assigned this Mar 28, 2024
@pavelsavara pavelsavara requested a review from maraf March 28, 2024 17:18
This was referenced Mar 28, 2024
Open
Open
This was referenced Apr 2, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@pavelsavara pavelsavara marked this pull request as ready for review April 3, 2024 06:42
@pavelsavara pavelsavara requested a review from lewing as a code owner April 3, 2024 06:42
@pavelsavara
Copy link
Member Author

/ba-g all the CI failures are known
#98578
#100421
#99888

@pavelsavara pavelsavara merged commit 8763f6d into dotnet:main Apr 3, 2024
94 of 98 checks passed
@pavelsavara pavelsavara deleted the browset_mt_pthread_pool_size branch April 3, 2024 07:52
@build-analysis build-analysis bot mentioned this pull request Apr 3, 2024
Closed
@pavelsavara pavelsavara mentioned this pull request Apr 15, 2024
Closed
31 tasks
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@pavelsavara @matouskozak
[browser][MT] smaller thread pool (dotnet#100415)
8a871fd
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@maraf maraf Awaiting requested review from maraf

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

[wasm-mt] Revisit the size of pthread pool for CI
2 participants
@pavelsavara @ilonatommy