-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Fix Playwright test times out/fails because target closed #100074
Conversation
Tagging subscribers to 'arch-wasm': @lewing |
Blocker:The test occasionally times out. The last log is
from CI log:
Another error type:
|
src/mono/wasm/Wasm.Build.Tests/TestAppScenarios/SignalRClientTests.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/testassets/BlazorHostedApp/BlazorHosted.Client/Program.cs
Outdated
Show resolved
Hide resolved
It does not fail anymore with the error from the original issues. Failure is not connected. |
Fixes #99961, #100307.
OnInitialized
toOnAfterRender
but we keptOnPageLoaded
to trigger the test, instead of waiting forOnAfterRender
to finish to make sure all buttons are loaded. Most of the times it worked fine but it was not reliable.OnAfterRender
multiple times and triggering the event chain even more than 10 times in one test, some of these connections already finished and closed the app, the others were in process and failed with error. Now we make sure we trigger it only once.