Revert change in StringBuilder.Append(char) (#74898)

The change has a bad interaction with inlining heuristics. Fixes #74158. Partial revert of #67448. Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet · Sep 3, 2022 · ce7e864 · ce7e864
1 parent 36c60aa
commit ce7e864
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/libraries/System.Private.CoreLib/src/System/Text/StringBuilder.cs b/src/libraries/System.Private.CoreLib/src/System/Text/StringBuilder.cs
@@ -1052,10 +1052,10 @@ public StringBuilder Append(char value)
             int nextCharIndex = m_ChunkLength;
             char[] chars = m_ChunkChars;
 
-            if ((uint)nextCharIndex < (uint)chars.Length)
+            if ((uint)chars.Length > (uint)nextCharIndex)
             {
                 chars[nextCharIndex] = value;
-                m_ChunkLength = nextCharIndex + 1;
+                m_ChunkLength++;
             }
             else
             {