Android: Opt out of edge to edge enforcement on api 35+ #25517
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #24742 for details. It seems to be a better compromise to disable this by default in MAUI apps. You can still opt out by including a similar style: ```xml <style name="DisableOptOutEdgeToEdgeEnforcement"> <item name="android:windowOptOutEdgeToEdgeEnforcement">false</item> </style> ``` And then applying it in a similar way, either by calling it before the `base.OnCreate(..)` in your activity subclass (in the OnCreate method override), or by registering for the ActivityOnCreate lifecycle callback. Eg: ```csharp protected override void OnCreate(Bundle? savedInstanceState) { // Disable Edge to Edge opt out by calling this before base.OnCreate() Theme?.ApplyStyle(Resource.Style.DisableOptOutEdgeToEdgeEnforcement, force: true); base.OnCreate(savedInstanceState); } ```
This will make it easier for devs to intentionally revert the implied opt-out of android 35 edge to edge enforcement behaviour that this PR also adds to MAUI.
Now all that's needed is to apply the disable style like this:
```csharp
protected override void OnCreate(Bundle? savedInstanceState)
{
Theme?.ApplyStyle(Microsoft.Maui.Resource.Style.DisableOptOutEdgeToEdgeEnforcement, force: true);
base.OnCreate(savedInstanceState);
}
```
| // Must be applied before the DecorView is setup | ||
| // We set force to false in case the style has already been explicitly | ||
| // applied to disable opting out of edge to edge enforcement | ||
| Theme?.ApplyStyle(Resource.Style.OptOutEdgeToEdgeEnforcement, force: false); |
There was a problem hiding this comment.
Would it work to set this in Maui.MainTheme:
<item name="android:windowOptOutEdgeToEdgeEnforcement">true</item>And just set it no matter what, probably doesn't do anything on API < 35?
This would avoid a C# -> Java call on startup.
Comment on lines
+6
to
+12
| <style name="OptOutEdgeToEdgeEnforcement"> | ||
| <item name="android:windowOptOutEdgeToEdgeEnforcement">true</item> | ||
| </style> | ||
|
|
||
| <style name="DisableOptOutEdgeToEdgeEnforcement"> | ||
| <item name="android:windowOptOutEdgeToEdgeEnforcement">false</item> | ||
| </style> |
There was a problem hiding this comment.
Then you wouldn't even really need these styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android 35+ enforces apps extending "Edge to Edge" by default. See #24742 for details.
For now, a better compromise is to disable this by default in MAUI apps, until we can provide better support for edge to edge within .NET MAUI itself as well as better safe area insets on Android.
If you still want to manually make your app more compatible with edge to edge, you can disable this implicit opt out by including a similar (inverse) style:
And then applying it in the same way by calling it before the
base.OnCreate(..)in your activity subclass (in the OnCreate method override):The new "Default" of opting out of the Edge to Edge enforcement on an Android 35+ device looks now like this:
If you revert to the old behaviour by disabling the opt out, it will look like this:
