Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nullable Context] Enable on Microsoft.Diagnostics.Monitoring.WebApi #6924

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

schmittjoseph
Copy link
Member

@schmittjoseph schmittjoseph commented Jul 1, 2024

Summary

This is the first PR in a series to enable nullable aware context throughout our code. To help with ease of review and minimize the chance of introducing regressions, I'll be organizing the PRs as follows:

  • Each project will have nullable aware context enabled in its own PR.

    • These PRs will be large but only contain trivial, low/no-risk, changes. Namely they'll primarily contain the addition of the new nullable syntaxes (? and !) and static analysis attributes (e.g. [NotNullWhen(..)]).
    • Nullable context will be disabled around pieces of code that contain some level of risk to update. These sections of code will be addressed in follow up PRs so they can be properly reviewed. (e.g. #nullable disable ... #nullable restore)
    • If you see anything that you feel like could introduce a regression or is non-trivial in these PRs, leave a comment and I'll pull out those changes.
  • All PRs in this effort will not contain any breaking changes.

Release Notes Entry

@schmittjoseph schmittjoseph marked this pull request as ready for review July 1, 2024 16:50
@schmittjoseph schmittjoseph requested a review from a team as a code owner July 1, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants