-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nullable Context] Enable on Microsoft.Diagnostics.Monitoring.WebApi
#6924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
commented
Jul 1, 2024
src/Microsoft.Diagnostics.Monitoring.WebApi/Validation/IntegerOrHexStringAttribute.cs
Show resolved
Hide resolved
schmittjoseph
commented
Jul 1, 2024
jander-msft
reviewed
Jul 1, 2024
src/Microsoft.Diagnostics.Monitoring.WebApi/DiagnosticServices.cs
Outdated
Show resolved
Hide resolved
jander-msft
reviewed
Jul 1, 2024
6 tasks
jander-msft
approved these changes
Jul 1, 2024
This was referenced Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first PR in a series to enable nullable aware context throughout our code. To help with ease of review and minimize the chance of introducing regressions, I'll be organizing the PRs as follows:
Each project will have nullable aware context enabled in its own PR.
?
and!
) and static analysis attributes (e.g.[NotNullWhen(..)]
).#nullable disable ... #nullable restore
)All PRs in this effort will not contain any breaking changes.
Release Notes Entry