Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition out internal authentication for VerifyDotnetFolderContents test #6009

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lbussell
Copy link
Contributor

@lbussell lbussell requested a review from a team as a code owner October 25, 2024 16:34
@lbussell lbussell requested review from NikolaMilosavljevic and removed request for a team October 25, 2024 16:34
@lbussell lbussell requested a review from a team October 25, 2024 16:34
@NikolaMilosavljevic
Copy link
Member

It's odd that #5928 did not hit this error in any of the checks. But, the fix seems correct.

@lbussell
Copy link
Contributor Author

It's odd that #5928 did not hit this error in any of the checks. But, the fix seems correct.

#5928 may not have built any/many Dockerfiles due to caching. However, I can't say why #5989 didn't hit any issues.

@lbussell lbussell enabled auto-merge (squash) October 25, 2024 16:56
@lbussell lbussell merged commit aed7253 into dotnet:nightly Oct 25, 2024
107 checks passed
@mthalman
Copy link
Member

It's odd that #5928 did not hit this error in any of the checks. But, the fix seems correct.

#5928 may not have built any/many Dockerfiles due to caching. However, I can't say why #5989 didn't hit any issues.

Caching doesn't affect testing. We still run tests even if images are cached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants