Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Audit Logging To SecreteManager.exe #4183

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Add Audit Logging To SecreteManager.exe #4183

wants to merge 51 commits into from
+466 −61

Commits on Sep 26, 2024

  1. Initial change to add secuirty audit logging capabilites and to updat… 

    …e the secrete manager command line operations to allow for passing in a service tree id associated with the service execuring change operations.
    @davfost
    davfost committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    05b8a68 View commit details
    Browse the repository at this point in the history

  2. Resolving merge conflicts with main

    @davfost
    davfost committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cd9b948 View commit details
    Browse the repository at this point in the history

  3. Resolving merge conflict with main

    @davfost
    davfost committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    7134128 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e661780 View commit details
    Browse the repository at this point in the history

  2. Adding logging for Key creation in Azure Key vaults 

    Changing variable names to be more consistent with use
Altering some comments
    @davfost
    davfost committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    87c81eb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7f74cda View commit details
    Browse the repository at this point in the history

  4. Removing temporary test project from solution.

    @davfost
    davfost committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    80629f8 View commit details
    Browse the repository at this point in the history

  5. Resorting using statements per PR comments

    @davfost
    davfost committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f71bee0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Update to address unit test failure and add capabilities to set globa… 

    …l and base command settings when not using the command line.
    @davfost
    davfost committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    cc6d25e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    db2f714 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6676fbe View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    45d061c View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8c4a7d3 View commit details
    Browse the repository at this point in the history

  2. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Info… 

    …Command.cs

Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
    @davfost @mmitche
    davfost and mmitche authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    665ec4c View commit details
    Browse the repository at this point in the history

  3. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Proj… 

    …ectBaseCommand.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e4e3ee6 View commit details
    Browse the repository at this point in the history

  4. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Proj… 

    …ectBaseCommand.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8cb0a82 View commit details
    Browse the repository at this point in the history

  5. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Proj… 

    …ectBaseCommand.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e7c01fa View commit details
    Browse the repository at this point in the history

  6. Update for PR comment. Thorw on bad Guid ID in arguments.

    @davfost
    davfost committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f92854a View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dev/davfost/20240710' of https://github.com/dotnet/dnceng… 

    … into dev/davfost/20240710
    @davfost
    davfost committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    8764fe8 View commit details
    Browse the repository at this point in the history

  8. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Vali… 

    …dateAllCommand.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    4e52cfe View commit details
    Browse the repository at this point in the history

  9. Update src/SecretManager/Microsoft.DncEng.SecretManager/ITokenCredent… 

    …ialProvider.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    10e3150 View commit details
    Browse the repository at this point in the history

  10. Update src/SecretManager/Microsoft.DncEng.SecretManager/SecurityAudit… 

    …Logger.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c964d13 View commit details
    Browse the repository at this point in the history

  11. Update src/SecretManager/Microsoft.DncEng.SecretManager/SecurityAudit… 

    …Logger.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9204ef1 View commit details
    Browse the repository at this point in the history

  12. Update src/SecretManager/Microsoft.DncEng.SecretManager/SecurityAudit… 

    …Logger.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    09eb38a View commit details
    Browse the repository at this point in the history

  13. Updates for PR comments. IpV6 support for GetLocalIpAddress

    @davfost
    davfost committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    d6a9dfc View commit details
    Browse the repository at this point in the history

  14. Merge branch 'dev/davfost/20240710' of https://github.com/dotnet/dnceng… 

    … into dev/davfost/20240710
    @davfost
    davfost committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    683509f View commit details
    Browse the repository at this point in the history

  15. Update src/SecretManager/Microsoft.DncEng.SecretManager/Program.cs 

    Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    00b4f16 View commit details
    Browse the repository at this point in the history

  16. Update src/SecretManager/Microsoft.DncEng.SecretManager/Program.cs 

    Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    21c7bfe View commit details
    Browse the repository at this point in the history

  17. Update src/SecretManager/Microsoft.DncEng.SecretManager/Program.cs 

    Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f752944 View commit details
    Browse the repository at this point in the history

  18. Update src/SecretManager/Microsoft.DncEng.SecretManager/StorageTypes/… 

    …AzureKeyVault.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c7e56da View commit details
    Browse the repository at this point in the history

  19. Update src/SecretManager/Microsoft.DncEng.SecretManager/StorageTypes/… 

    …AzureKeyVault.cs

Co-authored-by: Michael Stuckey <michael.stuckey@microsoft.com>
    @davfost @garath
    davfost and garath authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    507ce96 View commit details
    Browse the repository at this point in the history

  20. Update to resolve collisions from direct PR submitted changes.

    @davfost
    davfost committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    394d13c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Proj… 

    …ectBaseCommand.cs

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b53ab8e View commit details
    Browse the repository at this point in the history

  2. Update src/SecretManager/Microsoft.DncEng.SecretManager/Commands/Proj… 

    …ectBaseCommand.cs

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5ad6fe2 View commit details
    Browse the repository at this point in the history

  3. Updates to product altering ServiceTreeId from operation outside of c… 

    …ommnad option setting processes per PR comment.
    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b2ff903 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev/davfost/20240710' of https://github.com/dotnet/dnceng… 

    … into dev/davfost/20240710
    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    846b088 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0b204be View commit details
    Browse the repository at this point in the history

  6. Removing unneeded comments in dependency injection logic.

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0a93297 View commit details
    Browse the repository at this point in the history

  7. Updating SetCredentialIdentityValues to ensure it will not cause the … 

    …service setup to fail even if extracting claims throws an exception
    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c341bf7 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b5995a7 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/main' into dev/davfost/20240710

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    40c421f View commit details
    Browse the repository at this point in the history

  10. Update to use private 'set' for property definition instead of using … 

    …and interal private variable for data storage.
    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    5bd1293 View commit details
    Browse the repository at this point in the history

  11. Updating comment for servicetreeid based on PR comments.

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b5c497e View commit details
    Browse the repository at this point in the history

  12. Renaming ValidateServiceTreeIdOption for PR comments.

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b208ff4 View commit details
    Browse the repository at this point in the history

  13. Removing comments per PR comment

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    2fa7882 View commit details
    Browse the repository at this point in the history

  14. Remobing local testing project that was checked in by mistake.

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    939cbef View commit details
    Browse the repository at this point in the history

  15. Changing access level of _globalCommand and ServiceTreeId class varia… 

    …bles based on PR comments and an offline conversation to confirm using secretmanager as an assembly is not a supported scenario.
    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    0bbfd80 View commit details
    Browse the repository at this point in the history

  16. Update src/SecretManager/Microsoft.DncEng.SecretManager/Program.cs 

    Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    032f375 View commit details
    Browse the repository at this point in the history

  17. Update src/SecretManager/Microsoft.DncEng.SecretManager/SecretManager… 

    …CredentialProvider.cs

Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
    @davfost @dougbu
    davfost and dougbu authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    b70116d View commit details
    Browse the repository at this point in the history

  18. Making SetCredentialIdentityValues non volitile based on PR comments.

    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    f2253b6 View commit details
    Browse the repository at this point in the history

  19. Fixing a typo in the last change to make SetCredentialIdentityValues … 

    …non volitile.
    @davfost
    davfost committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    13199b5 View commit details
    Browse the repository at this point in the history