-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop net6 support #2927
base: main
Are you sure you want to change the base?
Drop net6 support #2927
Conversation
LGTM, I think you forgot to remove some more lines from the .nuspec file. |
Looks like this file can be deleted now:
|
It can. Almost everything beneath netcore/src/Common/System can join it, as can everything beneath netcore/src/Common/Interop/Unix, and quite a few files from netcore/src/Common/Interop/Windows. It'll also close #303 by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is definitely a minimal set of changes required for removing net6 support, there will be a lot of code removal required as well. If you can create an item in ado for that (and optionally assign to me), that'd be great. Any opportunity to remove derelect code is appreciated!
Azure Pipelines successfully started running 2 pipeline(s). |
- name: netcoreVersionTestUtils | ||
displayName: 'Netcore Version for Test Utilities' | ||
type: object | ||
default: net8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version is set here, but passed down through to the test util project compilation. Trying to keep this at the highest level possible so that it's easy to bump in the future without digging down in the individual jobs.
This PR includes the minimum necessary to drop net6 support.
I have two follow up PRs planned: