Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop net6 support #2927

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Drop net6 support #2927

wants to merge 8 commits into from

Conversation

mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Oct 25, 2024

This PR includes the minimum necessary to drop net6 support.

I have two follow up PRs planned:

  • update documentation and build guides
  • update net6 symbol checks to net8 in test and common directories and remove net6 symbol checks from the netcore directory

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 26, 2024

LGTM, I think you forgot to remove some more lines from the .nuspec file.

@ErikEJ
Copy link
Contributor

ErikEJ commented Oct 26, 2024

Looks like this file can be deleted now:

src\Microsoft.Data.SqlClient\src\Microsoft\Data\SqlClient\SSPI\ManagedSSPIContextProvider.cs

@edwardneal
Copy link
Contributor

It can. Almost everything beneath netcore/src/Common/System can join it, as can everything beneath netcore/src/Common/Interop/Unix, and quite a few files from netcore/src/Common/Interop/Windows. It'll also close #303 by default.

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is definitely a minimal set of changes required for removing net6 support, there will be a lot of code removal required as well. If you can create an item in ado for that (and optionally assign to me), that'd be great. Any opportunity to remove derelect code is appreciated!

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

- name: netcoreVersionTestUtils
displayName: 'Netcore Version for Test Utilities'
type: object
default: net8.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is set here, but passed down through to the test util project compilation. Trying to keep this at the highest level possible so that it's easy to bump in the future without digging down in the individual jobs.

@benrr101 benrr101 added this to the 6.0-preview3 milestone Oct 29, 2024
@mdaigle mdaigle added the 🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants