Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Templates for Windowing, OpenGL #748

Merged
merged 16 commits into from
Jan 19, 2023
Merged

Project Templates for Windowing, OpenGL #748

merged 16 commits into from
Jan 19, 2023

Conversation

ThomasMiz
Copy link
Contributor

Summary of the PR

C# Project templates for Windowing and OpenGL, as discussed in issue #738

@ThomasMiz ThomasMiz requested a review from a team as a code owner January 5, 2022 01:23
@ThomasMiz
Copy link
Contributor Author

I'd like an opinion on these initial project templates. What do you think?

Copy link
Member

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial thoughts

templates/Silk.NET.Templates/Silk.NET.Templates.csproj Outdated Show resolved Hide resolved
templates/Silk.NET.Templates/Silk.NET.Templates.csproj Outdated Show resolved Hide resolved
@Perksey
Copy link
Member

Perksey commented Jan 6, 2022

Oh by the way this looks amazing so far 😍

@Perksey
Copy link
Member

Perksey commented Jan 6, 2022

Can you fix this build error? Will just need to add the template projects to the NUKE acceptable exclusions!

A project has not been included in the solution and will not be shipped! "D:\a\Silk.NET\Silk.NET\templates\Silk.NET.Templates\Silk.NET.Templates.csproj" if this is acceptable please add the project name (excluding the path and extension) to the AllowedExclusions array in the NUKE Build.CI.AutoReview.cs file.

Thanks.

@f1WN356Uh51a1W6cn
Copy link

This looks really nice in my (beginner) opinion

@Perksey
Copy link
Member

Perksey commented Feb 4, 2022

These comments might be old as they've been pending for god knows how long

@Perksey
Copy link
Member

Perksey commented Feb 5, 2022

Merged main because CI decided it didn't want to run otherwise

@Perksey Perksey added this to the Next Working Group Meeting milestone Apr 30, 2022
@Perksey
Copy link
Member

Perksey commented Jan 7, 2023

  • Need to add implicit cast down to uint for strong type handles

  • Weren't of much value

  • What are users expecting from an example?

    • What are they expecting from OpenGL?
    • Never used OpenGL before? vs Never used Silk.NET before?
    • First exposure to Silk.NET?
    • If we move away from native repr a lot, it will be overwhelming (API may be perceived as different)
    • If they're expecting pure OpenGL, give them pure OpenGL.
  • Two separate examples could be overwhelming/confusing

  • Removing/deprecating doesn't make much sense

    • If we have them, don't need to remove them
  • 3.0 intends to make these more valuable

  • Tutorial should be minimal

    • e.g. classlib example, everyone removes Class1
  • Note in the tutorials "we're using uints but they exist"

  • Very polarizing.

  • Use uints

  • Link to tutorial in template to learn more

  • Have a page explaining the strongly typed handles

  • Easier to go 2D -> 3D

  • Very different to monogame/xna

  • Link to page explaining these

  • Adding comments to template balloons the template

  • Not ideal that the windowing backend behaves the way it does anyway

    • We'll accept a change of behaviour in the backend itself to change 24/8 to default
  • Follow GLFW default and use 24/8 in the templates

  • Stay consistent, set these in all templates

  • Alises?

    • silkgl -> silkglwindow
    • silkgltri -> silkgltriangle
  • Viewport on Load game vs window

  • Combine silkglgame and silkglwindow

  • More options at a basic stage = more opportunities for them to pick the wrong option and mess up

  • Not a lot of use cases for inputless window

  • Remove silkglwindow, rename silkglgame to silkgl

    • Update silkgltriangle to match, everything should have input context
  • silkwindow

  • silkglwindow --> (goodbye)

  • silkglgame --> silkgl

  • silkgltriangle --> silkgltriangle (but we should add the input from glgame)

  • Not dropping prefix

@Perksey Perksey requested a review from Beyley January 8, 2023 19:00
@Perksey Perksey removed this from the Next Working Group Meeting milestone Jan 8, 2023
@Perksey Perksey enabled auto-merge (squash) January 15, 2023 20:06
@Perksey Perksey merged commit 10d15f6 into main Jan 19, 2023
@Perksey Perksey deleted the feature/templates branch January 19, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants