-
-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More improvements to native library builds #2143
Conversation
…ader.Native. This was missed in #2049.
Vulkan Loader has GAS-style assembly that is essential to it functioning correctly, so to make things simple, we build on Linux using llvm-mingw.
This is needed since the default globs only include *.so on Linux.
…3.4.0: Fri Mar 15 00:10:50 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_VMAPPLE
This brings it in line with our Vulkan-Headers submodule.
This brings in a number of build system fixes that we need for win-arm64. This commit is just prior to the update to Vulkan v1.3.282.
…xrp/vulkan-loader-swiftshader-win-arm64/swiftshader_bins
… 23.4.0: Fri Mar 15 00:10:50 PDT 2024; root:xnu-10063.101.17~1/RELEASE_ARM64_VMAPPLE
…Ubuntu SMP Thu Mar 21 16:45:46 UTC 2024
…xrp/vulkan-loader-swiftshader-win-arm64/vulkan_loader_bins
…xrp/vulkan-loader-swiftshader-win-arm64/vulkan_loader_bins
…der-win-arm64/vulkan_loader_bins Update Vulkan Loader binaries
…untu SMP Thu Mar 21 16:45:46 UTC 2024
…xrp/vulkan-loader-swiftshader-win-arm64/swiftshader_bins
…der-win-arm64/swiftshader_bins Update SwiftShader binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few Qs, LGTM other than that
@@ -12,19 +14,7 @@ | |||
<PackageProjectUrl>https://github.com/dotnet/Silk.NET</PackageProjectUrl> | |||
<Description>Multi-platform native library for SwiftShader.</Description> | |||
<RepositoryType>git</RepositoryType> | |||
<RepositoryUrl>https://swiftshader.googlesource.com/SwiftShader/</RepositoryUrl> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But isn't this upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it would be better for auditing purposes to point to the repository that we actually produce artifacts from even if it's a mirror.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Beyley PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pona
* Fix #2026 * Fix #2000, closes #2005 * Fix #2010 * Fix added AL bug (good thing we had tests!) * Fix #1500 * Undo any unintentional changes * Add nint overloads for things like VertexAttribPointer * Fix build errors * Add more standard cursor shapes * Upversion natives where necessary * Patch notes for 2.21 * Reorder literally a single line * Incorporate #2143/#2066/#2090 in patch notes * Implement IsExtensionPresent for WGL * nit * OpenXR updates? * Fix flawed constant parsing for Vk/XR * Add openxr to patch notes * Update patch notes for 2.21
Closes #2066.
Closes #2090.