Issue 19716 Add MANPATH to activate(.fish) #367
Conversation
|
Thanks for your pull request and interest in making D better, @bolry! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
|
|
Thanks a lot for your PR, but could you please add a simple test for it? |
|
Will do. Travis is new to me but I'll have a look. |
|
It's basically just one big shell script which we run in the CI. Let me know if you need help. |
|
Seemingly I need some ideas about the travis runtime environment to check it. Maybe |
|
I presume LDC just doesn't come with a man page or has it somewhere else? |
|
I've changed to only add |
|
@bolry Request review and resolution of any conflicts associated with this pull request. Let's whip this in shape for merger. |
| @@ -710,17 +714,19 @@ write_env_vars() { | |||
| esac | |||
|
|
|||
| logV "Writing environment variables to $ROOT/$1/activate" | |||
| cat > "$ROOT/$1/activate" <<EOF | |||
| cat > "$ROOT/$1/activate" <<END_ACTIVATE | |||
There was a problem hiding this comment.
Why change this? EOF is kinda a standard for bash heredoc strings.
| # Check man pages do not destroy system man pages availability | ||
| if [[ $compiler = dmd* ]]; then | ||
| . ~/dlang/$compiler/activate | ||
| man dmd >/dev/null 2>&1 |
There was a problem hiding this comment.
Maybe grep for sth. like Digital Mars to ensure it worked properly?
| @@ -75,6 +75,13 @@ do | |||
| command -v dub >/dev/null 2>&1 || { echo >&2 "DUB hasn't been installed."; exit 1; } | |||
| deactivate | |||
|
|
|||
| # Check man pages do not destroy system man pages availability | |||
Add the MANPATH environment variable to both the
activateandactivate.fishgenerated scripts ininstall.sh. Gives access to man pages for, e.g., dmd and dmd.conf.