-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n #841
Open
TTWNO
wants to merge
76
commits into
djc:main
Choose a base branch
from
TTWNO:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
i18n #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added fail() if localize() is detected in a template while the localization feature is not activated
…ich tries until on parser succeeds but this also means when localize gets call with non localize string it fails and generates a failure This reverts commit 355163a.
Proc-macro askama_derive::i18n_load!() must remain in root namespace, due to restrictions in proc-macro exports. However, it is re-published as `askama::i18n::load!()`.
Resolve rework requests
docs: Rename example template struct
Quote from https://projectfluent.org/fluent/guide/hello.html ```ftl hello = Hello, world! ``` Each message has an identifier that allows the developer to bind it to the place in the software where it will be used. The above message is called `hello`.
fix: Implement missing recursive `is_cachable()` for `Expr::Localize`
Fix: Add missing trailing newline in ftl file
My feedback from #700 still stands, I guess:
Thanks for bringing this up to date, though! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR with the same basic features as #700 but up to date with current main.