Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n #841

Open
wants to merge 76 commits into
base: main
Choose a base branch
from
Open

i18n #841

wants to merge 76 commits into from

Conversation

TTWNO
Copy link

@TTWNO TTWNO commented Jul 16, 2023

A PR with the same basic features as #700 but up to date with current main.

89Q12 added 30 commits June 16, 2022 21:39
@89Q12
added language files for tests
f8af562
@89Q12
added htmls files to test translation
e9b1be5
@89Q12
added tests
9877915
@89Q12
added parser for localize(foo, bar: baz)
2eb0fdf
@89Q12
added tests for the localize parser
7d11fd2
@89Q12
added visit_localize, arm: Expr::Localize, field:localized_messages
8336929
@89Q12
added extraction for the locale field and localizer field
72dda5e
@89Q12
added locale attribute
858ea69
@89Q12
corrected locale attribute
465483d
@89Q12
added feature localization
39a1370
@89Q12
added #[cfg(feature = "localization")]
47cbb51
@89Q12
Fixed errors and added comment
1874729
@89Q12
fix cargo files
98ff019
@89Q12
fix test: test_parse_nested_localize
07db0e7
@89Q12
added #![cfg(feature = "localization")] to i18n tests
8bd252e
@89Q12
added askama::Local struct with impl
c96ada6
@89Q12
changed tests to use askama::Local
d1a46fe
@89Q12
removed init_translation macro since its not needed anymore
cdbc7d0
@89Q12
refactored no args test adn its template
4c7300c
@89Q12
Merge branch 'main' of https://github.com/11Tuvork28/askama into i18n
7e1f5e6
@89Q12
removed last todos
17f95e7
@89Q12
Added test for invalid tags with no fallack language
2c827f2
@89Q12
fixed lint error from Lint workflow
c3f5684
@89Q12
Fixed typo th -> the
2658da3
@89Q12
fixed test I messed up
7b89872
@89Q12
Added fn quoted_ident to support only localize("foo", bar:baz) and
5ce38a3 
added fail() if localize() is detected  in a template while the localization feature is not activated
@89Q12
Updated test templates -> quoted all messages
7a11db6
@89Q12
Added cut() to localze function
355163a
@89Q12
Revert "Added cut() to localze function" because expr_any uses alt wh…
62027c8 
…ich tries until on parser succeeds but this also means when localize gets call with non localize string it fails and generates a failure

This reverts commit 355163a.
@89Q12
HashMap<String, ...> to HashMap<&str, ...>
bbe5991
LeoniePhiline and others added 25 commits October 10, 2022 17:15
@LeoniePhiline
opinionated: Rename initialization macro localization! to i18n_load!
f944c86
@LeoniePhiline
style: Change wording "have to" to "need to"
c32b22d
@LeoniePhiline
refactor: Confine i18n code inside i18n modules
426575e 
Proc-macro askama_derive::i18n_load!() must remain in root namespace,
due to restrictions in proc-macro exports.
However, it is re-published as `askama::i18n::load!()`.
@LeoniePhiline
fix: Hide dependency fluent_templates from library users
81cce1a
@LeoniePhiline
fix(deps): Update dependency fluent-templates to 0.8.0
1c315d6
@LeoniePhiline
docs: Add initial i18n module documentation
6384ae2
@89Q12
Merge pull request djc#4 from LeoniePhiline/i18n
7f82494 
Resolve rework requests
@LeoniePhiline
docs: Rename example template struct
3f002ef
@89Q12
Merge branch 'djc:main' into i18n
925d1b5
@89Q12
Merge pull request djc#5 from LeoniePhiline/i18n
8f30ba5 
docs: Rename example template struct
@LeoniePhiline
fix: Implement missing recursive is_cachable() for Expr::Localize
b52aaf3
@LeoniePhiline
fix(style): Name localization message identifier as in Fluent Project
9909c36 
Quote from https://projectfluent.org/fluent/guide/hello.html

```ftl
hello = Hello, world!
```

Each message has an identifier that allows the developer to bind it to the place in the software where it will be used. The above message is called `hello`.
@LeoniePhiline
fix(style): Normalize test names, prefix all with test_
6cda9f5
@89Q12
Merge pull request djc#6 from LeoniePhiline/i18n
9e1f326 
fix: Implement missing recursive `is_cachable()` for `Expr::Localize`
@LeoniePhiline
fix: Add missing trailing newline
7c15904
@LeoniePhiline
Merge branch '11Tuvork28:i18n' into i18n
5c35e12
@LeoniePhiline
fix: Compilation without feature i18n failed
2bbba70
@89Q12
Merge pull request djc#7 from LeoniePhiline/i18n
b5dda4c 
Fix: Add missing trailing newline in ftl file
@89Q12
Merge branch 'djc:main' into i18n
f9dfa60
@TTWNO
Move i18n to seperated parser files
70dca43
@TTWNO
Fix toml/basic-toml dependency mismatch
47b7c6c
@TTWNO
Use path function instead of field
e1b66c8
@TTWNO
Update spelling of 'cacheable', and actually use expr_localized
b21ba00
@TTWNO
Fix conflict
4a3b1d0
@TTWNO
Cargo format
7a79974
@djc
Copy link
Owner

djc commented Jul 24, 2023 •
edited
Loading

My feedback from #700 still stands, I guess:

I guess the main thing that could help resolving this deadlock would be to represent the changes here as a series of a smaller PR that have one logical change per PR, so that I can review each of them quickly and thus we can make progress.

Thanks for bringing this up to date, though!

@TTWNO TTWNO mentioned this pull request Jul 30, 2023
Open
@89Q12 89Q12 mentioned this pull request Dec 18, 2023
Closed
@89Q12 89Q12 mentioned this pull request Jan 6, 2024
Open
@freedit-dev freedit-dev mentioned this pull request Feb 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TTWNO @djc @89Q12 @Kijewski @LeoniePhiline