Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages for truncated files #1050

Merged
merged 2 commits into from
May 17, 2024
Merged

Better error messages for truncated files #1050

merged 2 commits into from
May 17, 2024

Conversation

Kijewski
Copy link
Contributor

No description provided.

GuillaumeGomez
GuillaumeGomez reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement! Just one nit and looks good to me.

GuillaumeGomez
GuillaumeGomez approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kijewski Kijewski merged commit 38a2a86 into djc:main May 17, 2024
17 checks passed
@Kijewski Kijewski deleted the pr-missing-end branch May 17, 2024 17:02
@djc djc mentioned this pull request May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kijewski @GuillaumeGomez