Better error message for break/continue

djc · May 15, 2024 · fef27d2 · fef27d2
1 parent a77b4f0
commit fef27d2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/askama_parser/src/node.rs b/askama_parser/src/node.rs
@@ -87,7 +87,10 @@ impl<'a> Node<'a> {
         ));
         let (j, (pws, _, nws)) = p(i)?;
         if !s.is_in_loop() {
-            return Err(nom::Err::Failure(error_position!(i, ErrorKind::Tag)));
+            return Err(nom::Err::Failure(ErrorContext {
+                input: i,
+                message: Some(Cow::Borrowed("you can only `break` inside a `for` loop")),
+            }));
         }
         Ok((j, Self::Break(Ws(pws, nws))))
     }
@@ -100,7 +103,10 @@ impl<'a> Node<'a> {
         ));
         let (j, (pws, _, nws)) = p(i)?;
         if !s.is_in_loop() {
-            return Err(nom::Err::Failure(error_position!(i, ErrorKind::Tag)));
+            return Err(nom::Err::Failure(ErrorContext {
+                input: i,
+                message: Some(Cow::Borrowed("you can only `continue` inside a `for` loop")),
+            }));
         }
         Ok((j, Self::Continue(Ws(pws, nws))))
     }

diff --git a/testing/tests/ui/break_outside_of_loop.stderr b/testing/tests/ui/break_outside_of_loop.stderr
@@ -1,4 +1,5 @@
-error: failed to parse template source at row 1, column 9 near:
+error: you can only `break` inside a `for` loop
+       failed to parse template source at row 1, column 9 near:
        "break%}, have a parsing error!"
  --> tests/ui/break_outside_of_loop.rs:3:10
   |