Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added buttons #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArmanAirapetov
Copy link

No description provided.

Copy link
Owner

@dimonchik0036 dimonchik0036 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you add an example for a keyboard like https://github.com/dimonchik0036/vk-api/blob/master/messages_test.go#L7 and squash commits after fixing of comments?

var buttons []Button

for text, color := range textAndColorButtons {
button := new(Button)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to create button without new? Like

button := Button{
	Action: Action{
		Type:  "text",
		Label: text,
	},
	Color: color,
}

config := NewMessage(NewDstFromUserID(id), message)
values := addParameters(config)

keyboard := new(Keyboard)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants