Fix config not loading on Windows #483
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for elm-pages-todos pending review.Visit the deploys page to approve it
|
lishaduck
reviewed
Jul 18, 2024
|
|
||
| export async function resolveConfig() { | ||
| const configPath = path.join(process.cwd(), "elm-pages.config.mjs"); | ||
| const initialConfig = await await import( |
There was a problem hiding this comment.
Just me being creepy, dad 😅
Saw this on the GH homepage, took a look becuase I was curious.
Suggested change
| const initialConfig = await await import( | |
| const initialConfig = await import( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Windows machine, it was always printing this error message, even though there's a default config in place:
Looking more deeply into it, the following error was being thrown from the
importcall:This PR, therefore, always converts the file path into a file URL before attempting to import it.