support content detached JWS #310

xli · 2021-06-26T05:32:29Z

Extract out JWS module without offchain types to diem package. We will need jws encoding and decoding message for mini-wallet API authentication later.
Add content detached JWS support.

see #311 for the full plan.

src/diem/jws.py

tests/test_jws.py

src/diem/jws.py

tests/test_jws.py

CapCap · 2021-06-28T19:49:12Z

src/diem/jws.py

+
+
+def encode_headers(headers: Dict[str, Any]) -> bytes:
+ return encode_b64url(json.dumps(headers, separators=(",", ":")).encode(ENCODING))


is this going to return the same thing for {"two":"two","one":"one"} as it would for {"one":"one","two":"two"}? Should it? These headers are functionally equivalent, but here we would be depending on implementation to ensure the headers we get are ordered the same on different machines, right? And if they're not the same order, we could consider this signature invalid; is this the expected behaviour?

They are different, and it does not matter.

When you validate signature, you verify against the JWS message header and body parts, which is the result of this function.
As long as you can decode the bytes back to a dict with same keys and values, then it's fine.

xli requested review from sunmilee and CapCap June 26, 2021 05:32

xli force-pushed the jws branch from 06334bd to 70bf9ff Compare June 26, 2021 05:44