Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Diablo Version 1.08-Specific Behavior with Preprocessor Directives #2292

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

kphoenix137
Copy link
Contributor

@kphoenix137 kphoenix137 commented Mar 5, 2024

Build for version 1.08 binary. The difference between v1.09b and v1.08 is weighting in pathfinding, and fixing sound issues, however nothing in the original source had been changed between v1.09 and v1.09b, but rather using a different version of the directsound API

v1.08 path_get_h_cost() is found at 0x44A911
v1.09/v1.09b path_get_h_cost() is found at 0x4494D3

  1. CHANGES FROM 1.09 TO 1.09b
     (download only, not an automatic battle.net update)

        A. Fixed sound problem with Windows NT 4.

  2. CHANGES FROM 1.08 TO 1.09

        A. Fixed some Battle.net issues.
 
 Medium bugs (affecting gameplay)
        B. Reverted a change made in 1.08 that, while correctly calculated
           distance, caused unintended gameplay issues.
           ```

@kphoenix137 kphoenix137 changed the title Add preprocessor directive for version 1.08 Add Diablo Version 1.08-Specific Behavior with Preprocessor Directives Mar 5, 2024
@AJenbo
Copy link
Member

AJenbo commented Mar 5, 2024

Might want to add the flags here: https://github.com/diasurgical/devilution/blob/master/MakefileVC#L58

@kphoenix137 kphoenix137 marked this pull request as ready for review March 6, 2024 01:07
@kphoenix137
Copy link
Contributor Author

kphoenix137 commented Mar 6, 2024

I did a minor change that should allow better handling of building the binary based on targeted version of Diablo. This way we can conditionally handle changes that can span multiple Diablo versions. Perhaps then after another few PRs for different version logic, we could decouple HELLFIRE specific logic from VERSION < 105 specific logic to allow for targeting Hellfire in conjunction with different patches of Diablo (assuming someone would even want to do that).

@AJenbo AJenbo merged commit 27e6ef5 into diasurgical:master Mar 6, 2024
5 of 6 checks passed
@kphoenix137 kphoenix137 deleted the 108 branch March 6, 2024 04:33
@kphoenix137 kphoenix137 restored the 108 branch April 2, 2024 04:29
kphoenix137 added a commit to kphoenix137/devilution that referenced this pull request Aug 19, 2024
diasurgical#2292)

* add preprocessor directive for version 1.08

* Update MakefileVC

* Missed "endif"

* revise handling of diablo version
kphoenix137 added a commit to kphoenix137/devilution that referenced this pull request Aug 19, 2024
diasurgical#2292)

* add preprocessor directive for version 1.08

* Update MakefileVC

* Missed "endif"

* revise handling of diablo version
kphoenix137 added a commit to kphoenix137/devilution that referenced this pull request Aug 19, 2024
diasurgical#2292)

* add preprocessor directive for version 1.08

* Update MakefileVC

* Missed "endif"

* revise handling of diablo version
kphoenix137 added a commit to kphoenix137/devilution that referenced this pull request Aug 20, 2024
diasurgical#2292)

* add preprocessor directive for version 1.08

* Update MakefileVC

* Missed "endif"

* revise handling of diablo version
kphoenix137 added a commit to kphoenix137/devilution that referenced this pull request Aug 20, 2024
diasurgical#2292)

* add preprocessor directive for version 1.08

* Update MakefileVC

* Missed "endif"

* revise handling of diablo version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants