Fix: Incorrect directory path if tool is installed by package #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetektoza
force-pushed
the
fix_config_location_mismatch
branch
from
8a3f2f2
to
3db8cba
Compare
AJenbo
reviewed
Oct 20, 2023
AJenbo
reviewed
Oct 20, 2023
AJenbo
reviewed
Oct 20, 2023
Currently, if we install d1-graphics-tool with a .deb package, it will try to resolve the path to save a .json file to /usr/bin, since currently we save the configuration file wherever the binary is. User doesn't have an access to write to /usr/bin/ directly and this ends up with a problem in reading/writing to a config, resetting the config everytime app is being used. This patch changes it, and leaves the configuration for the file to be saved in: Windows: AppData/.config/diasurgical/d1-graphics-tool/ directory path Otherwise: /home/user/.config/diasurgical/d1-graphics-tool/ directory path
AJenbo
reviewed
Oct 20, 2023
tetektoza
force-pushed
the
fix_config_location_mismatch
branch
from
3db8cba
to
3fa4601
Compare
Adds documentation to config.cpp, for functions that were missing it and also for newly added createDirectoriesOnPath().
tetektoza
force-pushed
the
fix_config_location_mismatch
branch
from
3fa4601
to
ce4f28f
Compare
AJenbo
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if we install d1-graphics-tool with a .deb package, it will try to resolve the path to save a .json file to /usr/bin, since currently we save the configuration file wherever the binary is. User doesn't have an access to write to /usr/bin/ directly and this ends up with a problem in reading/writing to a config, resetting the config everytime app is being used.
This patch changes it, and leaves the configuration for the file to be saved in:
Also added missing documentation for config.cpp.