Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sections for new subnet_stats endpoint #351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

michael-weigelt
Copy link

@michael-weigelt michael-weigelt commented Oct 21, 2024

In certain circumstances, canisters wish to learn about subnet-specific data or metadata. This endpoint enables these use cases, starting with exposing the replica version a subnet is currently running.

Open questions:

  • Should this method be restricted to canisters or can any principal call it? Update: Yes, to pass on the cost to the caller
  • Naming: Is 'stats' fine if we anticipate that data like number of canisters, memory occupied etc might be added to the response struct? Update: Renamed to subnet_metrics

@michael-weigelt michael-weigelt requested a review from a team as a code owner October 21, 2024 13:38
Copy link

github-actions bot commented Oct 21, 2024

🤖 Here's your preview: https://pjpim-riaaa-aaaak-qckja-cai.icp0.io/docs

Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adambratschikaye
Copy link
Contributor

If a canister wants to get the information for it's own subnet, how is it supposed to figure out which subnet it is on?

@mraszyk
Copy link
Contributor

mraszyk commented Oct 24, 2024

If a canister wants to get the information for it's own subnet, how is it supposed to figure out which subnet it is on?

The registry has an endpoint that serves this information.

github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Oct 28, 2024
…lable to execution environment (#2248)

This is an alternative to #2248 and
#2082

This PR passes the running replica version to the execution environment,
from where it can be used [in a future management canister
call.](dfinity/interface-spec#351):
#2202

---------

Co-authored-by: Michael Weigelt <michael.weigelt@dfinity.com>
github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Oct 28, 2024
…lable to execution environment (#2248)

This is an alternative to #2248 and
#2082

This PR passes the running replica version to the execution environment,
from where it can be used [in a future management canister
call.](dfinity/interface-spec#351):
#2202

---------

Co-authored-by: Michael Weigelt <michael.weigelt@dfinity.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants