-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility #326
Open
maksymar
wants to merge
19
commits into
master
Choose a base branch
from
maksym/allowlist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Here's your preview: https://tsg2i-6qaaa-aaaak-qcpwa-cai.icp0.io/docs |
maksymar
commented
Jul 27, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
mraszyk
reviewed
Jul 29, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
maksymar
changed the title
feat: add allowlist variant to canister's log_visibility
feat: [EXC-1676] add allowlist variant to canister's log_visibility
Aug 5, 2024
maksymar
changed the title
feat: [EXC-1676] add allowlist variant to canister's log_visibility
feat: [EXC-1676] add allowed viewers variant to canister's log visibility
Aug 5, 2024
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
Aug 11, 2024
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
Dfinity-Bjoern
changed the title
feat: [EXC-1676] add allowed viewers variant to canister's log visibility
[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
allowed_viewers
variant to canister'slog_visibility
which allows to fetch logs by specified number of principals.