Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility #326

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

[FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility #326

wants to merge 19 commits into from

Conversation

maksymar
Copy link
Contributor

@maksymar maksymar commented Jul 27, 2024 •
edited
Loading

This PR adds allowed_viewers variant to canister's log_visibility which allows to fetch logs by specified number of principals.

@maksymar maksymar requested a review from a team as a code owner July 27, 2024 14:15
@maksymar maksymar requested a review from mraszyk July 27, 2024 14:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 27, 2024 •
edited
Loading

🤖 Here's your preview: https://tsg2i-6qaaa-aaaak-qcpwa-cai.icp0.io/docs

maksymar
maksymar commented Jul 27, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/_attachments/ic.did Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
@maksymar maksymar requested review from mraszyk and dsarlis July 29, 2024 09:36
mraszyk
mraszyk reviewed Jul 29, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
@maksymar maksymar requested a review from mraszyk July 30, 2024 05:57
@mraszyk

This comment was marked as resolved.

Sign in to view
@dsarlis

This comment was marked as resolved.

Sign in to view
@maksymar maksymar changed the title feat: add allowlist variant to canister's log_visibility feat: [EXC-1676] add allowlist variant to canister's log_visibility Aug 5, 2024
@maksymar maksymar changed the title feat: [EXC-1676] add allowlist variant to canister's log_visibility feat: [EXC-1676] add allowed viewers variant to canister's log visibility Aug 5, 2024
@maksymar maksymar mentioned this pull request Aug 8, 2024
Merged
@mraszyk

This comment was marked as resolved.

Sign in to view
mraszyk
mraszyk reviewed Aug 11, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
Dfinity-Bjoern
Dfinity-Bjoern reviewed Aug 20, 2024
View reviewed changes
spec/index.md Outdated Show resolved Hide resolved
Dfinity-Bjoern and others added 2 commits August 20, 2024 15:29
@Dfinity-Bjoern @mraszyk
Update spec/index.md
8dd4edb 
Co-authored-by: mraszyk <31483726+mraszyk@users.noreply.github.com>
@Dfinity-Bjoern
Update spec/index.md
95c04c1
@Dfinity-Bjoern Dfinity-Bjoern changed the title feat: [EXC-1676] add allowed viewers variant to canister's log visibility [FINAL] feat: [EXC-1676] add allowed viewers variant to canister's log visibility Aug 20, 2024
@dfx-json dfx-json requested a review from mraszyk October 23, 2024 19:56
@mraszyk
Copy link
Contributor

mraszyk commented Oct 24, 2024

@dfx-json The PR looks good to me, but the feature is still disabled in production so I haven't approved yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dfinity-Bjoern Dfinity-Bjoern Dfinity-Bjoern left review comments

@dsarlis dsarlis Awaiting requested review from dsarlis

@mraszyk mraszyk Awaiting requested review from mraszyk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maksymar @mraszyk @dsarlis @Dfinity-Bjoern