Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [NODE-1500] Re-enable nested tests #2252

Merged
merged 1 commit into from
Oct 25, 2024
Merged

fix: [NODE-1500] Re-enable nested tests #2252

merged 1 commit into from
Oct 25, 2024

Conversation

Bownairo
Copy link
Member

Since #2218, nested tests are back to running at a reasonable speed and passing tests.

@Bownairo Bownairo requested a review from a team as a code owner October 24, 2024 21:33
@github-actions github-actions bot added the fix label Oct 24, 2024
basvandijk
basvandijk approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@Bownairo
Copy link
Member Author

Bownairo commented Oct 24, 2024 •
edited
Loading

https://github.com/dfinity/ic/actions/runs/11507818921/job/32036436604 🤞

@Bownairo
Copy link
Member Author

https://github.com/dfinity/ic/actions/runs/11524180093/job/32083766126

@Bownairo Bownairo added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit a5ff2a7 Oct 25, 2024
31 of 36 checks passed
@Bownairo Bownairo deleted the eero/nested-tests branch October 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bownairo @basvandijk