-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cketh/ckERC20): proposal to upgrade ledger suite orchestrator and managed canisters #2239
base: master
Are you sure you want to change the base?
Conversation
git fetch | ||
git checkout e54d3fa34ded227c885d04e64505fa4b5d564743 | ||
cd rs/ethereum/ledger-suite-orchestrator | ||
didc encode -d ledger_suite_orchestrator.did -t '(OrchestratorArg)' '(variant { UpgradeArg = record {git_commit_hash = opt "e54d3fa34ded227c885d04e64505fa4b5d564743"; ledger_compressed_wasm_hash = opt "98a7b7391608dc4a554d6964bad24157b6aaf890a05bbaad3fcc92033d9c7b02"; index_compressed_wasm_hash = opt "07dd7a18d047ac41c37be9ea200dc1e0cbe4606bbc737d5dbb89f6e0a6e7450d"; archive_compressed_wasm_hash = opt "3ba6fee3ce3d311eef8df0220ac38a411802ee57c0d073847ef2cf3efa6c60ed"}})' | xxd -r -p | sha256sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hash output
dc97f53a8c9e15e34b3fe16a69f2621fd29d4d0e0f18687315c53cb533be3af2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hash output:
dc97f53a8c9e15e34b3fe16a69f2621fd29d4d0e0f18687315c53cb533be3af2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dc97f53a8c9e15e34b3fe16a69f2621fd29d4d0e0f18687315c53cb533be3af2
|
||
Git hash: `e54d3fa34ded227c885d04e64505fa4b5d564743` | ||
|
||
New compressed Wasm hash: `b72d9ce3a174b3f2a086cf60225177ae1b09036008e413592d0b17ad599a8614` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hash verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified
|
||
``` | ||
git fetch | ||
git checkout d4ee25b0865e89d3eaac13a60f0016d5e3296b31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the correct git commit hash?
It is not consistent with the upgrade arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for double-checking! This is a copy-paste error from the previous proposal!
git fetch | ||
git checkout e54d3fa34ded227c885d04e64505fa4b5d564743 | ||
cd rs/ethereum/ledger-suite-orchestrator | ||
didc encode -d ledger_suite_orchestrator.did -t '(OrchestratorArg)' '(variant { UpgradeArg = record {git_commit_hash = opt "e54d3fa34ded227c885d04e64505fa4b5d564743"; ledger_compressed_wasm_hash = opt "98a7b7391608dc4a554d6964bad24157b6aaf890a05bbaad3fcc92033d9c7b02"; index_compressed_wasm_hash = opt "07dd7a18d047ac41c37be9ea200dc1e0cbe4606bbc737d5dbb89f6e0a6e7450d"; archive_compressed_wasm_hash = opt "3ba6fee3ce3d311eef8df0220ac38a411802ee57c0d073847ef2cf3efa6c60ed"}})' | xxd -r -p | sha256sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashes verified:
$ sha256sum ./artifacts/canisters/ic-icrc1-ledger-u256.wasm.gz
98a7b7391608dc4a554d6964bad24157b6aaf890a05bbaad3fcc92033d9c7b02
$ sha256sum ./artifacts/canisters/ic-icrc1-index-ng-u256.wasm.gz
07dd7a18d047ac41c37be9ea200dc1e0cbe4606bbc737d5dbb89f6e0a6e7450d
$ sha256sum ./artifacts/canisters/ic-icrc1-archive-u256.wasm.gz
3ba6fee3ce3d311eef8df0220ac38a411802ee57c0d073847ef2cf3efa6c60ed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hashes verified!
Proposal to upgrade all ledger suites managed by the ledger suite orchestrator to the latest version.