Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IDX): use official docker images #2230

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(IDX): use official docker images #2230

merged 1 commit into from
Oct 24, 2024

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Oct 24, 2024

In the past, there were some official docker images (for static-file-server and jaeger) that we could not pull using rules_oci.

The issue seems to have been fixed in Bazel 7.

See: bazel-contrib/rules_oci#695

In the past, there were some official docker images (for
`static-file-server` and `jaeger`) that we could not pull using
`rules_oci`.

The issue seems to have been fixed in Bazel 7.

See: bazel-contrib/rules_oci#695
@github-actions github-actions bot added the fix label Oct 24, 2024
@nmattia nmattia marked this pull request as ready for review October 24, 2024 09:37
@nmattia nmattia requested a review from a team as a code owner October 24, 2024 09:37
@github-actions github-actions bot added the @idx label Oct 24, 2024
Copy link
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@nmattia nmattia added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit 9c09cff Oct 24, 2024
26 checks passed
@nmattia nmattia deleted the nm-official-images branch October 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants