Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sns): Add SnsRoot.reset_timers #2216

Merged
merged 16 commits into from
Oct 25, 2024
Merged

feat(sns): Add SnsRoot.reset_timers #2216

merged 16 commits into from
Oct 25, 2024

Conversation

aterga
Copy link
Contributor

@aterga aterga commented Oct 23, 2024 •
edited
Loading

This PR enables resetting timers used by the SNS Root canister.

< Previous PR |

@aterga aterga changed the base branch from master to arshavir/brush-up-sns-timer-tests-3 October 23, 2024 17:18
@github-actions github-actions bot added the feat label Oct 23, 2024
@aterga aterga mentioned this pull request Oct 23, 2024
Merged
@aterga aterga marked this pull request as ready for review October 23, 2024 18:29
@aterga aterga requested a review from a team as a code owner October 23, 2024 18:29
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2024
@aterga
chore(sns): Refactor rs/sns/integration_tests/src/timers.rs (#2214)
124ab18 
This PR refactors SNS timer-related integration tests.

< [Previous PR](#2211) | [Next
PR](#2216) >
Base automatically changed from arshavir/brush-up-sns-timer-tests-3 to master October 25, 2024 12:24
@aterga aterga enabled auto-merge October 25, 2024 12:58
@aterga aterga added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit aa91eca Oct 25, 2024
25 checks passed
@aterga aterga deleted the arshavir/brush-up-sns-timer-tests-4 branch October 25, 2024 19:16
@andrew-lee-work
Copy link
Contributor

LGTM.

I agree with that a reset with a 1-week cooldown is better than no reset functionality.

I suggest in the future changing the reset behavior to:

  1. validate the timer (i.e. check it is active and that its delay is reasonable)
  2. reset only if timer state is invalid

With this behavior we should be able to safely reduce the cooldown.

(copied from chat with @aterga)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-dfinity max-dfinity max-dfinity approved these changes

Assignees
No one assigned
Labels
feat @nns-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aterga @andrew-lee-work @max-dfinity @anchpop