-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ICP-Rosetta): FI-1540: add disburse of neuron functionality #2182
feat(ICP-Rosetta): FI-1540: add disburse of neuron functionality #2182
Conversation
rs/rosetta-api/icp/tests/system_tests/test_cases/neuron_management.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @NikolasHai !
IIUC, these are all new tests, and not refactored old system tests - if so, would it make sense to ask the NNS team to have a quick look as well to double-check that the neuron management is done as they would expect (I'm not sure I would consider myself an expert on this subject!)?
rs/rosetta-api/icp/tests/system_tests/test_cases/neuron_management.rs
Outdated
Show resolved
Hide resolved
…ment.rs Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
These tests should replace the old system tests and effectively test the same functionality. |
This MR proposes the following changes: 1. Add the functionality of disbursing a neuron to the ICP Rosetta client --------- Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
This MR proposes the following changes: