-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RES-151): support for multiple calls of the same function #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oggy-dfin
force-pushed
the
oggy/tla-multiple-calls
branch
from
October 18, 2024 09:12
b1f3702
to
1375b84
Compare
oggy-dfin
changed the title
feat(IC-1579): support for multiple calls of the same function
feat(RES-151): support for multiple calls of the same function
Oct 18, 2024
mraszyk
approved these changes
Oct 18, 2024
aterga
approved these changes
Oct 21, 2024
rs/tla_instrumentation/tla_instrumentation_proc_macros/src/lib.rs
Outdated
Show resolved
Hide resolved
Still need to make sure it works for all types of functions (async, non-async, methods and top-level)
oggy-dfin
force-pushed
the
oggy/tla-multiple-calls
branch
from
October 24, 2024 10:50
c3b9628
to
0edfce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the same function (e.g., ledger transfer) is called multiple times from an update method (e.g., disbursing a neuron, where we first burn the fees, and then transfer the disbursed amount), we need to allow the TLA model to distinguish in which context the function is being called. The contexts are defined through Pluscal labels. Thus:
tla_function
, which can (and should) be used in functions called in multiple contexts within the same update methodlog_label
macro to allow changing the context in the parent methodTransfer
label, we can have, e.g.,Burn_Fees_Transfer
in theBurn_Fees
context andTransfer_Disbursed_Transfer
inTransfer_Disbursed
context)The PR also includes some unrelated improvements to TLA error reporting (including reporting the source locations).