Skip to content

Commit

Permalink
nuke rules_proto
Browse files Browse the repository at this point in the history
  • Loading branch information
nmattia committed Sep 24, 2024
1 parent a6ceddb commit c3b1dfe
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 83 deletions.
10 changes: 4 additions & 6 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,16 @@ module(

bazel_dep(name = "rules_python", version = "0.35.0")


python_version = "3.10"
python = use_extension("@rules_python//python/extensions:python.bzl", "python")
python.toolchain(
python_version = "3.10", # TODO: note about pip using different version
)
python.toolchain( python_version = python_version)

pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")
pip.parse(
hub_name = "python_deps",
python_version = "3.10",
python_version = python_version,
requirements_lock = "//:requirements.txt",
#hub_name = # TODO
)
use_repo(pip, "python_deps")

Expand Down Expand Up @@ -55,7 +54,6 @@ bazel_dep(name = "bazel_skylib", version = "1.7.1")
bazel_dep(name = "aspect_bazel_lib", version = "2.9.0")

# Protobuf rules
bazel_dep(name = "rules_proto", version = "6.0.2")
bazel_dep(name = "rules_java", version = "7.11.1") # NOTE: for closure

# Docker/OCI & archive rules with image definitions
Expand Down
94 changes: 46 additions & 48 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 0 additions & 29 deletions WORKSPACE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -453,35 +453,6 @@ http_file(
url = "https://github.com/dfinity/subnet-rental-canister/releases/download/0.1.0/subnet_rental_canister.wasm",
)

# Import Python rules

#http_archive(
# name = "rules_python",
# sha256 = "9d04041ac92a0985e344235f5d946f71ac543f1b1565f2cdbc9a2aaee8adf55b",
# strip_prefix = "rules_python-0.26.0",
# url = "https://github.com/bazelbuild/rules_python/releases/download/0.26.0/rules_python-0.26.0.tar.gz",
#)
#
#load("@rules_python//python:repositories.bzl", "python_register_toolchains")
#
#python_register_toolchains(
# name = "python3_10",
# python_version = "3.10",
#)
#
#load("@python3_10//:defs.bzl", "interpreter")
#load("@rules_python//python:pip.bzl", "pip_parse")
#
#pip_parse(
# name = "python_deps",
# python_interpreter_target = interpreter,
# requirements_lock = "//:requirements.txt",
#)
#
#load("@python_deps//:requirements.bzl", "install_deps")
#
#install_deps()

# Financial Integration artifacts for upgrade testing

# first ic-icrc1-ledger release (see https://dashboard.internetcomputer.org/proposal/104499)
Expand Down

0 comments on commit c3b1dfe

Please sign in to comment.