Skip to content

Commit

Permalink
Fixed some tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-wong-dfinity-org committed Oct 24, 2024
1 parent d193251 commit 31eaf60
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions rs/nns/governance/tests/governance.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10135,14 +10135,17 @@ fn test_include_public_neurons_in_full_neurons() {

if is_private_neuron_enforcement_enabled() {
for neuron in &mut expected_full_neurons {
if neuron.known_neuron_data.is_some() {
neuron.visibility = Some(Visibility::Public as i32);
}
let visibility = &mut neuron.visibility;
if visibility.is_none() {
*visibility = Some(Visibility::Private as i32);
}
}
}

assert_eq!(list_neurons_response.full_neurons, expected_full_neurons,);
assert_eq!(list_neurons_response.full_neurons, expected_full_neurons);
}

/// Struct to help with the wait for quiet tests.
Expand Down Expand Up @@ -14151,15 +14154,20 @@ fn test_neuron_info_private_enforcement() {
];
main(neuron_id_to_expect_redact);

// Insepct visibility. This time, it should always be None.
for neuron_id in [
no_explicit_visibility_neuron.id.unwrap(),
private_neuron.id.unwrap(),
public_neuron.id.unwrap(),
known_neuron.id.unwrap(),
// Insepct visibility. This time, the no explicit visibility guy is shown as such.
for (neuron_id, expected_visibility) in [
(no_explicit_visibility_neuron.id.unwrap(), None),
(private_neuron.id.unwrap(), Some(Visibility::Private)),
(public_neuron.id.unwrap(), Some(Visibility::Public)),
(known_neuron.id.unwrap(), Some(Visibility::Public)),
] {
let neuron_info = governance.get_neuron_info(&neuron_id, controller).unwrap();
assert_eq!(neuron_info.visibility, None, "{:?}", neuron_info,);
assert_eq!(
neuron_info.visibility,
expected_visibility.map(|visibility| visibility as i32),
"{:?}",
neuron_info,
);
}
}
}
Expand Down

0 comments on commit 31eaf60

Please sign in to comment.