Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation correction: Toggles dont contain text as far as I know #924

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

theaddonn
Copy link
Contributor

// Default is the default value filled out in the input. The user may remove this value and fill out its
// own text. The text may contain Minecraft formatting codes.

This was likely copied over from the Input's default field.

I discovered this while reading df's form implementation to help implement and especially document my own in Rust. (Thanks for all the comments in both df and gophertunnel, they are really helpful and I did not copy the comments 1:1 for the record)

This is a giant pr, so be warned!

This was likely copied over from the Input's default field
@iAmFrogger
Copy link

Thank you for this HUGE pr, But there are ALOT of BC breaks and I'm not sure GitHub can merge this.

@TwistedAsylumMC TwistedAsylumMC merged commit 8391c81 into df-mc:master Oct 3, 2024
1 check passed
@TwistedAsylumMC
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants