-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dotnet lts fix #1003
base: main
Are you sure you want to change the base?
dotnet lts fix #1003
Changes from all commits
5825c0d
b86fa8a
d9adda7
c214372
0023871
6a14771
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
# | ||
# Docs: https://github.com/devcontainers/features/tree/main/src/dotnet | ||
# Maintainer: The Dev Container spec maintainers | ||
DOTNET_VERSION="${VERSION:-"latest"}" | ||
DOTNET_VERSION="${VERSION:-"lts"}" | ||
ADDITIONAL_VERSIONS="${ADDITIONALVERSIONS:-""}" | ||
DOTNET_RUNTIME_VERSIONS="${DOTNETRUNTIMEVERSIONS:-""}" | ||
ASPNETCORE_RUNTIME_VERSIONS="${ASPNETCORERUNTIMEVERSIONS:-""}" | ||
|
@@ -105,7 +105,7 @@ done | |
|
||
# Install .NET versions and dependencies | ||
# icu-devtools includes dependencies for .NET | ||
check_packages wget ca-certificates icu-devtools | ||
check_packages wget ca-certificates icu-devtools curl jq | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps you could drop |
||
|
||
for version in "${versions[@]}"; do | ||
install_sdk "$version" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,9 @@ fetch_latest_version_in_channel() { | |
wget -qO- "https://dotnetcli.azureedge.net/dotnet/Runtime/$channel/latest.version" | ||
elif [ "$runtime" = "aspnetcore" ]; then | ||
wget -qO- "https://dotnetcli.azureedge.net/dotnet/aspnetcore/Runtime/$channel/latest.version" | ||
elif [ "$channel" = "LTS" ]; then | ||
echo $(curl -s https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am thinking it would be good to replace all usages of |
||
jq --raw-output '[."releases-index"[] | select(."release-type"=="lts" and ."support-phase"=="active")."latest-sdk"] | first') | ||
else | ||
wget -qO- "https://dotnetcli.azureedge.net/dotnet/Sdk/$channel/latest.version" | ||
fi | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -87,7 +87,7 @@ | |
"remoteUser": "vscode", | ||
"features": { | ||
"dotnet": { | ||
"version": "latest", | ||
"version": "lts", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same remark, if not needed for testing, I would revert this. |
||
"workloads": "aspire, wasm-tools" | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this was just for testing but otherwise I wouldn't change the default version