snap #89
Open
snap #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added snapcraft.yaml to build [snap](https://snapcraft.io/).
|
Once confined I don't think that Dell recovery would work as a snap as if needs a recovery partition and access to other things in the filesystem such as a USB key creating app and DVD creating app. As such I think it's likely better suited as a classic snap. |
|
Looks good. Would you mind adding a CI target to build it too? |
|
hi @superm1, I can add a Travis CI config file to build the snap. I'll add it to the snap folder later today. |
Added .travis.yml config file to build snap.
|
I think you need to merge it with the "top" level travis.yaml. It doesn't look like travis runs stuff that is in subdirectories. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added snapcraft.yaml to build snap.