-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): 411 overview dashboard core services #471
Conversation
@BillyFigueroa looks good! do the displayed "names" of the services need to be changed, though, given the Figma design? (e.g. Authorization, Monitoring, Service Mesh...) |
Just chatted with @Madeline-UX about this, these names should (ideally) line up with the UDS functional layers |
Also (again just chatted with @Madeline-UX ), let's remove the "View Service >" link for now |
The links were removed in this commit. Should we ask design to remove from the mocks? |
@BillyFigueroa sorry to add another comment 😅 but i think there's 2 issues happening. Apologies if you're already aware of them.
|
Hi Tristan,
|
I did |
Not sure if its just me. But pulled down the latest updates, running a newly created k3d cluster, so no core service. But now i cant select any of the views, but if I manually type in the path to view pods for example, then the view menu starts working again..... |
I could not re-create this. Maybe someone else can try |
@decleaver this might be an ignorant question because I do not understand how to handle errors in go but should this actually be considered an error when we don't have a crd? are most of these resources an array? Could we not just return an empty array in these cases? I see this is being handled in the k8s/store.ts i.e if ($resources.length > 0 && typeof $resources[0].resource === 'string') {
if ($resources[0].resource === 'crd not found') {
this.numResources.set(0)
return $resources
}
} I remember this was causing an issue with one of the tables before. I will add some logic in the |
Yeah, so this is a little bit of a special case where if we just returned an empty array, we wouldn't be able to tell if the cluster doesn't have any of those resources or if the custom resource definition for that resource exists in the cluster, and if the CRD doesn't exist, we want to let the users know that. This could be something we revisit and find a cleaner way to handle though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paired to address last fixes
Description
As a consumer of UDS Runtime, I would like to view a summary of core services, status and a corresponding link to view the service
Additional context
Figma Design
https://www.figma.com/design/zmKcJ9Xin7ChzyGy6RCFLe/UDS-Runtime-(UI%2FCLI)?node-id=4325-5166&m=dev
Related Issue
Screenshots
With Services
With out Services