Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add checkpoint uds-core slim package #818
base: main
Are you sure you want to change the base?
feat: add checkpoint uds-core slim package #818
Changes from 34 commits
80a9892
59d8999
2b74bd5
895d53a
68a03ae
7a09a33
7d86107
a853265
6af295e
c1e3e54
c1a457e
88e0aa6
6e24a4a
db1aeef
7cff415
9296753
98bd274
964786b
4788325
a05b23c
34235c9
d8a12b2
e34b0de
ca35214
2211d71
b3cb482
d1abeee
d84c408
4046f6f
cb9db50
3adc01d
2b0c083
43a4ec2
830b978
e72901a
401d88c
aaea091
5cb166b
2336dc7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During creation I see these errors (which cause the deploy to fail later):
I think pretty much universally on macOS docker is run inside of a VM, in my case the VM can be accessed with
colima ssh
but docker desktop, rancher desktop, etc would likely have similar issues and ways to access the VM.I was able to rewrite a portion of this script to use
docker cp
instead and got closer (at least didn't get errors with the volumes). I think this is probably a better, more agnostic option here and simplifies a lot of this logic (no looping through volumes, just copy the two paths we need explicitly). I was hoping it might also remove the need forsudo
but in my case one of the paths gave some permission errors still until I added sudo. I'm sure there's some efficiency loss here, but since it's create time I think it's worth it to make this work across distros? In my run locally it took less than a minute still to run which still seems decently performant (granted I couldn't get it to run successfully previously so unsure of the real comparison).Would be curious your thoughts on this - I dropped the script changes into a gist since there were a handful of changes across the entirety of the file: https://gist.github.com/mjnagel/6d681678df83067169c4e652466f704f
I also had to add
--no-xattrs
to the final tar command, I got warnings/errors without this (suspect that's some macOS <> Linux stuff). This got me much closer but I hit some issues with the token:I tried to tweak the commands around startup (using the k3d
--token
option rather than k3s arg) and validated the token exists after extraction but couldn't figure this one out. Would be curious if you hit the same issue with my modified script and can figure out what's wrong?