-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove nascent state tracking #942
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: catsby <clint@ctshryock.com>
Signed-off-by: catsby <clint@ctshryock.com>
catsby
changed the title
chore: Remove nascent state tracking
chore: remove nascent state tracking
Sep 24, 2024
Signed-off-by: catsby <clint@ctshryock.com>
Signed-off-by: catsby <clint@ctshryock.com>
catsby
requested review from
UncleGedd,
jeff-mccoy,
decleaver and
TristanHoladay
as code owners
September 24, 2024 21:29
UncleGedd
reviewed
Sep 24, 2024
Signed-off-by: catsby <clint@ctshryock.com>
UncleGedd
approved these changes
Sep 25, 2024
catsby
added a commit
that referenced
this pull request
Oct 1, 2024
* main: chore(deps): update actions/checkout action to v4.2.0 (#943) fix: add suffix to smoke test logs (#947) chore: matrix testing pre-existing k3d clusters (#944) chore: remove nascent state tracking (#942) fix: ensure runtime bins are included in releases (#939) chore: update uds ui docs (#937) fix: update maru-runner to silence info log (#925) chore: manually bump uds-runtime to v0.4.0 (#938) chore(deps): update module github.com/prometheus/common to v0.59.1 (#877) fix(deps): update kubernetes packages to v0.31.1 (#932) fix(deps): update module github.com/defenseunicorns/maru-runner to v0.2.3 (#933) fix(deps): update module github.com/defenseunicorns/pkg/oci to v1.0.2 (#934) chore(deps): update defenseunicorns/uds-common action to v0.13.0 (#935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An initial implementation of the idea of tracking state was added in #868 (along with a --prune flag in 883). After release we found some issues with it and have decided to remove it for now.
Related Issue
Relates to #868, #883, #893, #905, #909
Type of change
NOTE: While state was released in v0.15.0, the feature and usage itself was behind a disabled feature flag, so removing it
Checklist before merging