Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go version for ci #79

Merged
merged 2 commits into from
Oct 12, 2023
Merged

update go version for ci #79

merged 2 commits into from
Oct 12, 2023

Conversation

corang
Copy link
Contributor

@corang corang commented Oct 12, 2023

No description provided.

@UncleGedd
Copy link
Collaborator

Hey thanks for this @corang , could you also make the update in go.mod (and any other references to that old version of Go that I'm not thinking of)?

@corang
Copy link
Contributor Author

corang commented Oct 12, 2023

tbh I don't really know how to do that, is it just updating the value in the go.mod?

@UncleGedd
Copy link
Collaborator

tbh I don't really know how to do that, is it just updating the value in the go.mod?

Yep exactly, just bump the version in the go.mod and run go mod tidy (not sure if the go mod tidy will actually change anything but we'll all need to do it anyway)

UncleGedd
UncleGedd approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@UncleGedd UncleGedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@UncleGedd UncleGedd merged commit 6c0a261 into main Oct 12, 2023
6 checks passed
@UncleGedd UncleGedd deleted the go-version-fix branch October 12, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UncleGedd UncleGedd UncleGedd approved these changes

@mikevanhemert mikevanhemert Awaiting requested review from mikevanhemert

@jeff-mccoy jeff-mccoy Awaiting requested review from jeff-mccoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corang @UncleGedd