Update Makefile build-cli target #46
Conversation
Updated to have a build-cli target that will automatically build the appropriate binary based on your system and arch.
|
This may not be necessary. Just started playing in this repo. Feel free to ignore. |
There was a problem hiding this comment.
I saw the above comment after I made this review, but still submitting as if this was a more serious PR (but not requesting changes). As this PR stands, don't think the benefits outweigh the costs of this change. I leave it up to @UncleGedd .
| @@ -1,7 +1,38 @@ | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
| # SPDX-FileCopyrightText: 2023-Present The UDS Authors | |||
|
|
|||
| ARCH ?= amd64 | |||
| # Figure what operating system and arch we are on. | |||
| # Set some variables used to build the apporpriate binary | |||
There was a problem hiding this comment.
| # Set some variables used to build the apporpriate binary | |
| # Set some variables used to build the appropriate binary |
| make build-cli-linux-amd | ||
| make build-cli |
There was a problem hiding this comment.
Are there plans to support other arches for UDS CLI releases? As it stands right now only linux/amd64 will be supported.
There was a problem hiding this comment.
We should at least be supporting darwin/arm64. Honestly we should be supporting linux/amd64, linux/arm64 and darwin/arm64. I have nothing to say about windows. 😏
But it makes no sense to released this tool that we have to develop with without supporting the platforms we develop on (primarily linux/amd64, darwin/arm64).
I can build from source every time but that's kind of annoying. If for some reason we only "support" releases of linux/amd64, then i should still be able to run make build from my m2 mac and be able to build the binary for my correct platform without me having to fuss with it.
There was a problem hiding this comment.
+1 haven't read through this PR yet but UDS CLI in its current form should run on Linux or Mac arm/amd architectures
| build-cli-linux-amd: ## Build the CLI for Linux AMD64 | ||
| CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -ldflags="$(BUILD_ARGS)" -o build/uds main.go | ||
|
|
||
| build-cli-linux-arm: ## Build the CLI for Linux ARM64 | ||
| CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -ldflags="$(BUILD_ARGS)" -o build/uds-arm main.go | ||
|
|
||
| build-cli-mac-intel: ## Build the CLI for Mac Intel | ||
| GOOS=darwin GOARCH=amd64 go build -ldflags="$(BUILD_ARGS)" -o build/uds-mac-intel main.go | ||
|
|
||
| build-cli-mac-apple: ## Build the CLI for Mac Apple | ||
| GOOS=darwin GOARCH=arm64 go build -ldflags="$(BUILD_ARGS)" -o build/uds-mac-apple main.go | ||
| build-cli: ## Build the CLI | ||
| CGO_ENABLED="${CGO}" GOOS="${UNAME_S}" GOARCH="${ARCH}" go build -ldflags="$(BUILD_ARGS)" -o "${OUTPUT}" main.go |
There was a problem hiding this comment.
If you want to cross compile, you now need to do make build-cli ARCH=arm64 UNAME_S=darwin OUTPUT=build/uds-mac-apple instead of make build-cli-mac-apple. I would reflect this change in the README or somewhere discoverable, as it would be very easy to mix up these args and build a binary for the wrong arch / system that gets outputted to the wrong name.
|
Do you want me to put any more effort into this? If so, I can update based on all these comments. I can also close it if not so its not just sitting here. @UncleGedd |
Really appreciate you showing me how this works after you guys mentioned it last week. Personally I'm not a fan of all the new |
Updated to have a build-cli target that will automatically build the appropriate binary based on your system and arch.