fix: need inputs (#11)

defenseunicorns · Mar 9, 2024 · 1737ad9 · 1737ad9
1 parent 50e0eb9
commit 1737ad9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/examples/complete/main.tf b/examples/complete/main.tf
@@ -110,12 +110,14 @@ locals {
       transit_gateway_vpc_attachment_id = null
       static_routes = [
         {
-          blackhole              = false
-          destination_cidr_block = "0.0.0.0/0"
+          blackhole                           = false
+          destination_cidr_block              = "0.0.0.0/0"
+          route_transit_gateway_attachment_id = null
         },
         {
-          blackhole              = false
-          destination_cidr_block = module.vpc_prod.vpc_cidr_block
+          blackhole                           = false
+          destination_cidr_block              = module.vpc_prod.vpc_cidr_block
+          route_transit_gateway_attachment_id = null
         }
       ]
     },
@@ -131,8 +133,9 @@ locals {
       transit_gateway_vpc_attachment_id = null
       static_routes = [
         {
-          blackhole              = false
-          destination_cidr_block = module.vpc_dev.vpc_cidr_block
+          blackhole                           = false
+          destination_cidr_block              = module.vpc_dev.vpc_cidr_block
+          route_transit_gateway_attachment_id = null
         }
       ]
     }
@@ -173,12 +176,12 @@ locals {
         {
           blackhole                           = false
           destination_cidr_block              = module.vpc_dev.vpc_cidr_block
-          route_transit_gateway_attachment_id = ""
+          route_transit_gateway_attachment_id = null
         },
         {
           blackhole                           = false
           destination_cidr_block              = "0.0.0.0/0"
-          route_transit_gateway_attachment_id = ""
+          route_transit_gateway_attachment_id = null
         },
       ]
     }

diff --git a/modules/transit_gateway_route/main.tf b/modules/transit_gateway_route/main.tf
@@ -7,7 +7,7 @@ locals {
       "bh_${tostring(rc.blackhole)}"])
       ) => {
       destination_cidr_block              = rc.destination_cidr_block,
-      route_transit_gateway_attachment_id = rc.route_transit_gateway_attachment_id != "" ? rc.route_transit_gateway_attachment_id : (rc.blackhole ? null : var.vpc_transit_gateway_attachment_id),
+      route_transit_gateway_attachment_id = rc.route_transit_gateway_attachment_id != null && rc.route_transit_gateway_attachment_id != "" ? rc.route_transit_gateway_attachment_id : (rc.blackhole ? null : var.vpc_transit_gateway_attachment_id),
       blackhole                           = rc.blackhole
     }
   }