[iQue] Match some fs files #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
Thar0
approved these changes
Apr 27, 2024
src/bb/fs/fsclose.c
Outdated
| BbFat16* fat; | ||
| s32 rv; | ||
|
|
||
| if ((u32)fd >= BB_INODE16_NUM) { |
There was a problem hiding this comment.
Suggested change
| if ((u32)fd >= BB_INODE16_NUM) { | |
| if (fd < 0 || fd >= BB_INODE16_NUM) { |
This has matched elsewhere and is a bit more natural
src/bb/fs/fsdelete.c
Outdated
| } | ||
|
|
||
| bzero(&fat->inode[i], sizeof(fat->inode[i])); | ||
| rv = __osBbFsSync(0); |
There was a problem hiding this comment.
Suggested change
| rv = __osBbFsSync(0); | |
| rv = __osBbFsSync(FALSE); |
src/bb/fs/fsdir.c
Outdated
| } | ||
|
|
||
| rv++; | ||
| if ((d != NULL) && (j < count)) { |
There was a problem hiding this comment.
Suggested change
| if ((d != NULL) && (j < count)) { | |
| if (d != NULL && j < count) { |
imo parens should only be used where necessary or when operator precedence is unclear. Here it is clear that comparisons come before logical operators.
src/bb/fs/fsstat.c
Outdated
| u16 b = in->block; | ||
| i = 0; | ||
|
|
||
| for (i = 0; b != 0xFFFF && i < listLen; i++) { | ||
| blockList[i] = b; | ||
| b = fat[b >> 0xC].entry[(b & 0xFFF)]; | ||
| b = fat[b / 0x1000].entry[b % 0x1000]; |
There was a problem hiding this comment.
In one of the fs files I worked on I was unable to get it to match with div and mod. I think we should use shift and mask and probably macro this whole expression, e.g. b = BBFS_NEXT_BLOCK(fat, b), since it comes up so often
Co-authored-by: Tharo <17233964+Thar0@users.noreply.github.com>
Thar0
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches
fsclose.c,fsdelete.c,fsdir.c,fsread.c,fsrename.candfswrite.c