Matched 2.0I and 2.0J, fixed matched object count calculation #53
Conversation
src/io/leodiskinit.c
Outdated
| OSPiHandle *__osDiskHandle; | ||
|
|
||
| OSPiHandle *osLeoDiskInit() { | ||
| u32 saveMask; |
There was a problem hiding this comment.
Hmm I think some of the code files you added used tabs intsead of 4 spaces. Not sure where they all are.
|
I do think a formatter would be a good idea, but there are a lot of files in this codebase that already have tab indentation and changing those would be outside the scope of this PR. |
| #ifdef _DEBUG | ||
| assert(source); | ||
| #if BUILD_VERSION < VERSION_J | ||
| #line 74 |
There was a problem hiding this comment.
Isn't this redundant? This #line 74 is placed exactly in line 74, or does it apply to the very next statement?
There was a problem hiding this comment.
Yup #line sets the line number of the next line, not the current one.
| if (fxmix < 0) { // Not possible | ||
| update->data.i = -fxmix; | ||
| } else { | ||
| update->data.i = fxmix; | ||
| } |
There was a problem hiding this comment.
This is how it was in the original source, changing it to a ternary for an ABS macro breaks matching on libgultra_d.
| if (fxmix < 0) { // Not possible | ||
| fxmix = -fxmix; | ||
| } |
There was a problem hiding this comment.
Ditto on it breaking matching.
No description provided.